Skip to content

Show plugin names in file opener menus - #5241

Closed
brsbl wants to merge 3 commits into
mainfrom
bb/draft-editor-requires-manual-save-thr_kfd893acyi
Closed

brsbl wants to merge 3 commits into
mainfrom
bb/draft-editor-requires-manual-save-thr_kfd893acyi

Conversation

@brsbl

@brsbl brsbl commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

File opener labels used internal plugin IDs or generic titles, making installed plugins such as Docs difficult to identify.

What changed

  • File opener settings and both file-link menus show plugin names, such as “Docs (Markdown).”
  • Automatic selections identify the plugin while saved preferences keep their existing IDs.
  • When an opener's title repeats its plugin name (the bundled File Editor), the name shows once.

How you verified

  • Chrome for Testing 155 (headless) on isolated QA builds of 599c051 and 74ba862 with the bundled Docs and File Editor plugins: Settings → Files dropdowns (.md, .ts) at 1440×900 and 390×844, the thread file-link context menu, and the Docs file-link “Open with” submenu show plugin names; File Editor shows once (no “File Editor (File Editor)”).
  • Selecting “Docs (Markdown)” for .md stored {"md":"simple-notes:docs"} and stayed selected after a hard reload; no console errors.
  • Remote CI passed on 74ba862, including a regression test for the repeated-name label.
  • Slop Cop on f411b13 (rebased head): one P1, the doubled "File Editor (File Editor)" label, fixed in 74ba862. No other P0/P1.

Follow-ups (P2, not in this PR):

  • Add label tests for the two file-link menus, which only the settings test covers today.
  • "Automatic (Docs)" doesn't name the opener when one plugin registers several for an extension.
  • The SDK doc for a file opener's title still calls it the "Open with" label; it is now a qualifier after the plugin name.

User QA pending.

Before: 599c051 · After: 74ba862 · Captured at 2×

Screen / state Viewport Before After
Settings → File openers / .md dropdown open Desktop · 1440×900 Before .md opener settings After .md opener settings
Settings → File openers / .ts dropdown open Desktop · 1440×900 Before .ts opener settings After .ts opener settings
Settings → File openers / .md dropdown open Mobile · 390×844 Before .md opener settings on mobile After .md opener settings on mobile
Settings → File openers / .ts dropdown open Mobile · 390×844 Before .ts opener settings on mobile After .ts opener settings on mobile
Docs file link / Open with submenu Desktop · 1440×900 Before Docs file link Open with After Docs file link Open with
Thread message .md link / context menu Desktop · 1440×900 Before thread .md link menu After thread .md link menu
Thread message .ts link / context menu Desktop · 1440×900 Before thread .ts link menu After thread .ts link menu

BB-Thread-ID: thr_kfd893acyi

AGENT GENERATED

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T05:24:37.075443Z 9c70565 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@brsbl

brsbl commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Closing: low value right now (brsbl's call, Oct 19). The branch stays in case we want it later.

@brsbl brsbl closed this Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant